On Tue, 21 Jul 2026 23:31:40 GMT, John Hendrikx <[email protected]> wrote:
>> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java >> line 879: >> >>> 877: /* >>> 878: * The other node is now transitioned to the same state. Since >>> the value of -fx-boom >>> 879: * could not be evaluated, the value is reset to its default >>> value (1.0). >> >> shouldn't it be the value specified by the stylesheet? 41.0, since the >> styling of the `other` has not encountered an error? > > You are right that `41.0` would make more sense here, but that's assuming we > could get that value at all. The source of the exception used here is just to > test the `SKIP` adding code path (as it is crucial now that we add `SKIP` or > a value for every value in the CSS metadata). The path I was testing however > is *normally* only triggered when `lookup` fails, and when that fails there > simply isn't a value to put in the cache at all (ie. wrong type in the CSS or > you used a reference that doesn't exist). `applyStyle` isn't allowed to > throw exception, so results are "best effort" (and how this worked is > pre-existing, I didn't change it). My understanding is that if one control fails to applyStyle, the other control (which encountered no issues) should pick up the values from the stylesheet, and certainly not the default. Or am I missing something? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2218#discussion_r3640768168
