On Wed, 29 Jul 2026 23:29:09 GMT, John Hendrikx <[email protected]> wrote:
>>> New `CssMetaData` doc change looks good. We should wait what >>> @kevinrushforth if this needs a CSR or not. >> >> The doc change by itself seems reasonable, and I'd be OK doing it without a >> CSR. The only question I have then is regarding the behavioral change >> itself: would a "reasonable application" be surprised by the new behavior? >> If not, then we can skip the CSR. > >> > New `CssMetaData` doc change looks good. We should wait what >> > @kevinrushforth if this needs a CSR or not. >> >> The doc change by itself seems reasonable, and I'd be OK doing it without a >> CSR. The only question I have then is regarding the behavioral change >> itself: would a "reasonable application" be surprised by the new behavior? >> If not, then we can skip the CSR. > > I don't think so, in fact, I don't think a reasonable application could even > detect the difference without digging deep into CSS specifics -- the > `isSettable` method is called regardless in both new and old version, the > only difference is in how the CSS system acts on it (still looking up the > resolved CSS value, instead of not doing anything at all). The `applyStyle` > would not be called in either case, so there is no risk that a lazy property > would be created early either. @hjohn Then I think the last 'blocker' is the warning in the PR body: `Title mismatch between PR and JBS for issue JDK-8388378`. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2218#issuecomment-5129521456
