On Sat, 1 Aug 2026 03:02:51 GMT, Nir Lisker <[email protected]> wrote:
>> modules/javafx.base/src/main/java/javafx/util/converter/BaseStringConverter.java
>> line 51:
>>
>>> 49: abstract T fromNonEmptyString(String string);
>>> 50:
>>> 51: /// {@inheritDoc} `null` is converted to an empty string, otherwise
>>> the type's `toString` is used.
>>
>> I don't think the javadoc in this class is being processed; we probably need
>> to copy the text to all the descendants or the base class:
>>
>> <img width="381" height="695" alt="Image"
>> src="https://github.com/user-attachments/assets/83fb71c1-5f90-48d5-8643-cda48d495ac1";
>> />
>
> I remember that it used to work. Looks like the behavior was changed:
> https://stackoverflow.com/questions/67693537/javadoc-of-package-private-interfaces-methods-is-not-inherited-since-java-9
Wait, it *does* work. You're looking at `DefaultStringConverter`, the only
class that doesn't inherit from `BaseStringConverter` and has its own docs (the
behavior that was chosen for the parsing and formatting is rather inconsistent
and seems incidental, but that's what we have). Here's
`BigDecimalStringConverter`:
<img width="1093" height="545" alt="image"
src="https://github.com/user-attachments/assets/21c4fbb9-5b6d-4737-b416-6afc0dee514c";
/>
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1880#discussion_r3694481407
