On Tue, 4 Aug 2026 16:41:44 GMT, Kevin Rushforth <[email protected]> wrote:
>> @kevinrushforth
>> If so, then I think we need to release the sample after a failed
>> `GetGstBuffer` as well, am I right?
>> Like
>>
>> if (GetGstBuffer != NULL)
>> GetGstBuffer(&m_pBuffer, m_lSize, &m_UserData);
>>
>> if (m_pBuffer == NULL)
>> {
>> pSample->Release();
>> *ppBuffer = NULL;
>> return E_FAIL;
>> }
>
> Yes, I think you are right, except that `pSample` hasn't yet been assigned
> (so the assignment of `pSample` would need to be moved up).
Pushed the changes
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2234#discussion_r3714546657
