On Tue, 4 Aug 2026 22:54:40 GMT, Kevin Rushforth <[email protected]> wrote:
>> modules/javafx.base/src/main/java/javafx/util/StringConverter.java line 35: >> >>> 33: /// >>> 34: /// @implNote JavaFX's implementations are immutable, but might not be >>> thread-safe: the same converter can be reused as >>> 35: /// long as all access are on the same thread or are synchronized. >>> Implementing classes are not required to be immutable. >> >> Better. However, I see that `FormatStringConverter`, >> `NumberStringConverter`, and `DateTimeStringConverter` take a user-provided >> format object and store a reference to that object, so calling those >> converters "immutable" is misleading. If the caller mutates the format >> object after passing it to the converter, it will change the behavior of >> future conversion operations. So I would either list those classes as >> exceptions or remove the immutability claim. >> >> Also, there is a grammatical error: "all access are on the same thread" >> should be "access is" or "accesses are". > > (and I realize that I was the one who introduced the grammatical error in my > suggestion) if the debugging is the process of removing the bugs, then programming is... ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1880#discussion_r3716769907
