On Wed, 5 Aug 2026 16:23:54 GMT, Andy Goryachev <[email protected]> wrote:

> > and would also require moving more code
> 
> yes, that's my point - it will help identify which code needs to be extracted 
> into the common class(es). the main danger here, I think, is sometime down 
> the road we might discover that the API needed to be different because of 
> some reason.
> 
> this PR is going to marinate for a while I am sure, so it's up to you.
> 
> edit: also, `BorderPane` is much more interesting from the testing 
> perspective than the `StackPane`.

Yeah, I understand that last one. I can add it when you're ready to start 
testing -- I just need to move a few more functions from Region to 
LayoutSupport then (to avoid code duplication). The end game is that almost all 
of those functions will be moved there anyway -- only the protected/public 
stuff can't be touched.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2241#issuecomment-5197186010

Reply via email to