> Fixes double check locking by adding the `volatile` keyword.
> 
> During normal operation, the access seems to happen from two threads:
> 
> Thread[#29,QuantumRenderer-0,5,main]
> Thread[#34,JavaFX Application Thread,5,main]
> 
> 
> On one hand, this access is likely to be mutually exclusive, on the other 
> hand, javafx does allow the nodes to be created in a background thread, and 
> it might be possible to invoke, for example, `GlyphLayout.breakRuns()` from a 
> background thread.
> 
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Andy Goryachev has updated the pull request with a new target base due to a 
merge or a rebase. The incremental webrev excludes the unrelated changes 
brought in by the merge/rebase. The pull request contains three additional 
commits since the last revision:

 - Merge branch 'master' into 8387684.volatile
 - proper initialization
 - volatile

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/2205/files
  - new: https://git.openjdk.org/jfx/pull/2205/files/bab8376f..f7d2dec0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=2205&range=02
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=2205&range=01-02

  Stats: 457539 lines in 11955 files changed: 262535 ins; 113370 del; 81634 mod
  Patch: https://git.openjdk.org/jfx/pull/2205.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/2205/head:pull/2205

PR: https://git.openjdk.org/jfx/pull/2205

Reply via email to