On Fri, 7 Aug 2026 01:10:31 GMT, Nir Lisker <[email protected]> wrote:

> * Adds the missing .h files as inputs.
> * Names the input properties for `-i` debug info.
> * Removes a redundant nested output dir.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Sanity build is good, suggesting a minor change.

build.gradle line 2501:

> 2499:                   }).withPropertyName("hlslSources")
> 2500:             
> inputs.file("$prismD3DSource/PassThroughVS.hlsl").withPropertyName("PassThroughVsSources")
> 2501:             outputs.dir "$buildDir/headers/PrismD3D/"

Please remove the `.withPropertyName("")` calls, as thee seem un-required for 
this change.

-------------

Changes requested by arapte (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/2252#pullrequestreview-4951173122
PR Review Comment: https://git.openjdk.org/jfx/pull/2252#discussion_r3796013645

Reply via email to