On Wed, 19 Aug 2026 14:02:09 GMT, Marius Hanl <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove empty tag
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/Region.java line
> 1610:
>
>> 1608: */
>> 1609: @Override protected double computeMinWidth(double height) {
>> 1610: return getInsets().getLeft() + getInsets().getRight();
>
> not relevant for this PR, but should this be snapped in the future? Or do you
> think this is better as default?
Yes, it should be snapped.
> modules/javafx.graphics/src/main/java/javafx/scene/layout/package-info.java
> line 349:
>
>> 347: * combined sum of such elements, each semantic role can require a
>> different decision:
>> 348: * <ul>
>> 349: * <li>Snapping too early can lose precision, while snapping too
>> late can introduce errors.
>
> There is no closing `</li>` tag here and below.
> I'm not sure if this is really needed. But probably best practise to do so.
It's not needed, and we almost always omit it in javadocs. At least that's my
impression for the past few years.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2260#discussion_r3819321487
PR Review Comment: https://git.openjdk.org/jfx/pull/2260#discussion_r3819316450
