On Thu, 20 Aug 2026 14:30:03 GMT, Andy Goryachev <[email protected]> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/javafx/util/ImageUtils.java 
>> line 163:
>> 
>>> 161:         }
>>> 162:         switch (fxFormat.getType()) {
>>> 163:             default:
>> 
>> Minor, also if you like: The `default` branch is the first. Looks very 
>> weird, should be the last instead
>
> I thought about reformatting the original file, and decided against it, to 
> speed up the review.
> On the other hand, I like cleaning up code...

I might leave this for a follow-up cleanup bug. It will be easier to review and 
ensure no regressions if the code that was copied from javafx.swing is 
unchanged (basically everything except the image write came from there).

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2267#discussion_r3822757729

Reply via email to