On Wed, 19 Aug 2026 20:16:43 GMT, Kevin Rushforth <[email protected]> wrote:
>> Marius Hanl has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 16 additional >> commits since the last revision: >> >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 833146-mvn-publish >> - fix gradle warning >> - Also match :all task name as outlined in Gradle best practices >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 833146-mvn-publish >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 833146-mvn-publish >> - all task build the publication now >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 833146-mvn-publish >> - Use defineProperty and fail method from default build.gradle >> - Depend maven publishing on the build modules task >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 833146-mvn-publish >> - ... and 6 more: https://git.openjdk.org/jfx/compare/45b9a2a6...ff79685e > > maven-publish.gradle line 34: > >> 32: >> 33: defineProperty("MAVEN_PUBLISH", "false") >> 34: ext.IS_MAVEN_PUBLISH = Boolean.parseBoolean(MAVEN_PUBLISH) || >> isAllTaskRequested() > > This flag was formerly `false` by default even when running `gradle all`. Are > there other side effect to now setting this flag to `true`? Did you consider > a separate flag that qualifies the creation of the `publications` dir? It's > probably OK as-is, since I didn't see any issues with the build. There is no side effect, it should behave as before. Another idea I just got: We could similar as before always call `configureMavenPublication` but it will only execute the tasks during `gradle all`, as before anyway. This will make the code a bit better. (My initial approach was to combine the Maven publishing and the `publications` folder. But based on your comments, that are two separate things really). Pushed the changes. On a side note, I was wondering if we even need `IS_MAVEN_PUBLISH`. The artifacts are only published when running Gradle with `publishToMavenLocal` anyway. So when `MAVEN_PUBLISH` is false, `publishToMavenLocal` is not found and does not work since we don't apply the plugin. Setting `MAVEN_PUBLISH` to true without `publishToMavenLocal` will apply the plugin but do nothing. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1970#discussion_r3823520651
