On Thu, 20 Aug 2026 17:23:36 GMT, Andy Goryachev <[email protected]> wrote:
>> The test StubToolkit is somewhat deficient by design - it also cannot scale >> images. >> >> You are right, checking for non-null byte[] is silly (it comes from the >> ByteArrayOutputStream). I've left the test in place to test for lack of >> exceptions, basically. > > We could split the test, but the main point is to test the utility API, not > the `StubToolkit`. As long as there are no exceptions we should be fine. > > (We could also fix the `StubToolkit` similarly to what we did for the > `TextLayout`, but I doubt the value of that effort). fine for me. I think improving the `StubWritablePlatformImage` might be worth it, just for the sake of a little bit better tests. But for another day ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2267#discussion_r3823835322
