On Wed, 19 Aug 2026 18:46:49 GMT, Kevin Rushforth <[email protected]> wrote:
>> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8305842: Replace qtdemux with MP4 demux based on Media Foundation [v8] > > modules/javafx.media/src/main/native/gstreamer/plugins/mfwrapper/mfwrapper.cpp > line 588: > >> 586: >> 587: HRESULT hr = mfwrapper_create_sample_from_gst_buffer(&pSample, buf, >> 588: decoder->force_discontinuity); > > This field is never set. Changed to `is_force_discontinuity`. > modules/javafx.media/src/main/native/gstreamer/plugins/mfwrapper/mfwrapper.h > line 77: > >> 75: gboolean is_eos; >> 76: gboolean is_decoder_initialized; >> 77: gboolean force_discontinuity; > > This field is used, but never set. Is there a reason to add what looks like a > duplicate of the existing `is_force_discontinuity` field? Merge conflict. We should use `is_force_discontinuity`. I will fix it by removing `force_discontinuity`. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2206#discussion_r3825834785 PR Review Comment: https://git.openjdk.org/jfx/pull/2206#discussion_r3825831559
