On Fri, 21 Aug 2026 19:09:30 GMT, Andy Goryachev <[email protected]> wrote:
>> eduardsdv has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8389970: Disable mnemonic processing on mac
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/LabelSkinTest.java
> line 2189:
>
>> 2187: StringBuilder sb = new StringBuilder();
>> 2188:
>> 2189: provide_testMnemonics_parameters().forEach(a -> {
>
> could this be converted to a simple parameterized test?
> or the sequence is important?
Same question, should be a `@MethodSource("provide_testMnemonics_parameters")`
as well
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/LabelSkinTest.java
> line 2252:
>
>> 2250: }
>> 2251:
>> 2252: private static <T> List<T> listOf(T... a) {
>
> isn't this a standard `List.of()`?
Yes, should be used instead
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2253#discussion_r3851667761
PR Review Comment: https://git.openjdk.org/jfx/pull/2253#discussion_r3851636228
