On Mon, 31 Aug 2026 23:30:05 GMT, Jose Pereda <[email protected]> wrote:

>> Fixes broken navigation introduced in 
>> [JDK-8370902](https://bugs.openjdk.org/browse/JDK-8370902) with non-zero 
>> paragraph spacing (above, below, line spacing).
>> 
>> Updated the Rich Editor Demo to allow setting paragraph line spacing in 
>> addition to space above/below (right click -> Paragraph).
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/RichTextAreaBehavior.java
>  line 684:
> 
>> 682:         double y = down ?
>> 683:             ci.getMaxY() + ci.getLineSpacing() + deltaPixels + 1.0 :
>> 684:             ci.getMinY() + deltaPixels - 1.0;
> 
> Any reason for the change in those constants, worth a small comment?

this is a very good question.  I think any reasonable constant would work, as 
long as it's outside the current text boundaries (and not more than the 
next/previous line height).  I don't expect font size = 1.

added a comment.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2280#discussion_r3907521633

Reply via email to