On Wed, 2 Sep 2026 21:06:51 GMT, Nir Lisker <[email protected]> wrote:
>> I mean the `synchronized` blocks. You're testing concurrent access. If I >> remove those blocks, I expect the test to fail. >> >> The parameter values I use depend on what produces a failure reliably. > > Well, what does this test test then? Your points 1 and 5 are about lack of > thread safety. A test that they are resolved should fail before the fix and > not fail after, unless you think that it's trivial, and then there's no need > for a test. well, it did fail twice in a row with threadCount = 49, but would pass afterwards. we **know** the `HashMap` will fail if it's not synchronized, what is the point of testing it? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2197#discussion_r3918676252
