On Thu, 3 Sep 2026 09:31:34 GMT, Marius Hanl <[email protected]> wrote:
> This is an idea to move out the `:apps` build from the `build.gradle`. > And to add an `INCLUDE_APPS` flag, that is now `false` by default to control > whether we actually want to build the `:apps` when running `gradle all` or if > we actually need to clean them when running `gradle clean`. > > I see two advantages: > - IMO, the main `build.gradle` should focus on JavaFX and not so much on > anything else, like apps > - As of now, when I did run `gradle clean`, I always need to install `Ant`, > just because the apps are also cleaned which I did not even build before. > This is problematic, because: > - I think most of the people do not have `Ant`, it is very rarely used > nowadays > - It is also not preinstalled in pretty much every OS / distribution I > tried. And I usually only installed for `OpenJFX` and never need it for > anything else. If possible, it would be good if this is not needed if you > just want to run tests and build JavaFX > - For reference, when running CachyOS I could just build JavaFX out of > the box without ever installing anything. This is a very nice experience and > should help people to contribute. The only thing I did run into was, well, > `Ant` when running `gradle clean` > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). I'll take a look at this at some point, but whatever is done, the default needs to remain such that `gradle all` builds the apps. build.gradle line 480: > 478: // When disabled, the "apps", "appsjar" and "clean" tasks will not > compile or clean the apps in there. > 479: defineProperty("INCLUDE_APPS", "false") > 480: ext.IS_INCLUDE_APPS = Boolean.parseBoolean(INCLUDE_APPS) No, `gradle all` needs to build the apps without any extra flags. ------------- Changes requested by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/2291#pullrequestreview-5106125917 PR Review Comment: https://git.openjdk.org/jfx/pull/2291#discussion_r3928109494
