On Mon, 10 Aug 2026 21:44:08 GMT, Thiago Milczarek Sayao <[email protected]> wrote:
>> This is a continuation to >> [JDK-8236651](https://bugs.openjdk.org/browse/JDK-8236651) and it aims to >> stabilize the linux glass gtk backend. >> >> It refactors the Glass GTK implementation with a primary focus on window >> sizing, positioning, and state management, addressing a number of >> long-standing issues. >> >> Previously, three separate context classes existed, two of which were used >> for Java Web Start and Applets. These have been unified, as they are no >> longer required. >> >> Additional tests have been introduced to improve coverage. Some tests >> produced different results depending on the StageStyle, so they have been >> converted to use `@ParameterizedTest` to exercise multiple styles. >> >> Although the primary focus is XWayland, the changes have also been verified >> to work correctly on Xorg. >> >> This replaces #1789. It removes the use of GdkWindow in favor of GtkWindow, >> reducing risk and simplifying the review process while preserving the same >> set of bug fixes. Additionally, #2025 requires a `GtkWindow` to be used when >> setting the parent of the file chooser dialog. >> >> To show debug messages, build with `-PCONF=DebugNative` and run with >> `-Djdk.gtk.verbose=true`. Log categories can be passed with >> `-Dglass.gtk.logCategories=CATEGORY` >> >> `CATEGORY` can be one or more of: >> - all >> - size >> - position >> - focus >> - state >> - lifecycle >> - input >> - dialog >> >> Multiple categories can be specified by separating them with commas (e.g. >> size,focus,input). >> >> A manual test is provided: >> `java @build/run.args tests/manual/stage/TestStage.java` >> >> When a window property is set, it is reported immediately. However, once it >> reaches the native Glass layer, it may be adjusted or rejected, causing the >> property to be updated again. Introducing a delay helps ensure the final >> state has been applied before it is verified. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Thiago Milczarek Sayao has updated the pull request with a new target base > due to a merge or a rebase. The pull request now contains 43 commits: > > - Merge branch 'master' into 8354943_v2 > - mapped = true for popups > - Do not block sent configure events, as doing so breaks screen-change > detection. > - - Restore gdk_event_request_motions (it's needed even without event > compression) > - Remove cursor unref (it's aready de-referenced on gdk_window_set_cursor) > - Improve XComposite message > - Remove configurable delays > - Fix test > - Xorg fixes > - Revert "Rewrite WrongStageFocusWithApplicationModalityTest because it > fails intermittently" > > This reverts commit c6b9dd745e5d762adb89a3b596e53b0d8a790d7f. > - Rewrite WrongStageFocusWithApplicationModalityTest because it fails > intermittently > - Use existing verbose flag for GTK > - ... and 33 more: https://git.openjdk.org/jfx/compare/58a7bea2...969ed5f3 This PR should merge in master again. I tested it, especially if it improves issues I found on Linux and for now, it looks very good. It actually fixes a very annoying dialog bug for me, where the dialog is not correcty layouted for the very first time. See here, only reproducable on Linux, fixed with your PR: [dialog.webm](https://github.com/user-attachments/assets/dcf8a907-e7fe-4d83-8c11-dc9658876d94) ------------- PR Comment: https://git.openjdk.org/jfx/pull/2139#issuecomment-5551699608
