On Wed, 9 Sep 2026 01:36:07 GMT, Michael Strauß <[email protected]> wrote:
> When a binary stylesheet contains CSS transitions, deserialization fails with > errors similar to: > > SEVERE: could not deserialize com.sun.javafx.css.TransitionDefinitionConverter > > > The reason is that the `StyleConverter.getInstance(String)` factory used to > deserialize converters doesn't include the converters that were added to > support CSS transitions. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). I want to ask a philosophical question: what can we do to avoid missing these kinds of dependencies in the future? Some kind of annotation? A comment in the base class? Maybe a test that inspects the classpath looking for specific subclasses and checks whether they are covered? What do you think? modules/javafx.graphics/src/test/java/test/javafx/css/StylesheetTest.java line 820: > 818: transition-duration: 160ms, 0.2s; > 819: transition-delay: 0s, -20ms; > 820: transition-timing-function: ease-out, linear; looks like the test is incomplete, `cubic-bezier()` and `steps()` fail to serialize, example: `transition-timing-function: cubic-bezier(0.2, 0.4, 0.8, 1.0);` ------------- Changes requested by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2303#pullrequestreview-5159503437 PR Review Comment: https://git.openjdk.org/jfx/pull/2303#discussion_r3972702309
