On Thu, 10 Sep 2026 17:03:51 GMT, Andy Goryachev <[email protected]> wrote:
>> Although we probably never need to account for bytes or shorts, since we >> only have four primitive number types in JavaFX anyway. > > Right, so FX implementation might be too lenient in that respect. We could > probably discuss it in a separate thread - should we print a warning, fail > the style, truncate as it is now. > > For the purposes of serialization - I don't think we care about anything else > but double and integer, since we can't differentiate a byte 1, short 1, long > 1, and we could not possibly care about integer values outside of the range > supported by double (-9,007,199,254,740,992 ... 9,007,199,254,740,992) > > which brings me to the original question: why do we need to serialize all > these types? or am I missing something? We need at least Double and Integer, as these types are already used in CssParser. For example, the `steps()` function parses its argument as an Integer, so this is the type that the serializer will see at runtime. This means that at the very least, the serializer must support those two types. The question is this: since we're about to change the BSS format, should we already include float and long, even though CssParser currently doesn't parse these? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2303#discussion_r3981639978
