On Mon, 21 Sep 2026 17:30:05 GMT, Nir Lisker <[email protected]> wrote:
>> Update for the 3D lighting test tool as described in the JBS issue. >> >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Remove unused source This is a test app, so perhaps a good README.md is in order, describing: - features - dependencies - how to control tests/performance/3DLighting/src/main/java/app/CameraScene3D.java line 126: > 124: case PRIMARY -> pan(deltaX, deltaY); > 125: case SECONDARY -> { > 126: if (e.isShiftDown()) { thank you. the rotation is still counter-intuitive, but at least it can be done in both axes. how does the user know about controls? should the control gestures be described in the main app javadoc or a `README.md` ? tests/performance/3DLighting/src/main/java/app/Controls.java line 161: > 159: titlePane.setGraphic(titleControls); > 160: titlePane.setExpanded(false); > 161: return titlePane; are "AmbientLights" sections supposed to expand? if not, it's probably wrong control for the puspose <img width="320" height="115" alt="Image" src="https://github.com/user-attachments/assets/e5b952b7-2e80-4cda-b581-4a2055ce0e89"; /> tests/performance/3DLighting/src/main/java/app/Environment.java line 67: > 65: // Reuse the background from the [PhongMaterial] docs instead of > copying it to the resources of this project. > 66: static { > 67: Path path = > Path.of("").toAbsolutePath().getParent().getParent().getParent() // jfx root should this dependency be documented? possibly in a readme.md? tests/performance/3DLighting/src/main/java/app/Environment.java line 172: > 170: var graphic = new Text("📷"); > 171: graphic.setBoundsType(TextBoundsType.VISUAL); > 172: graphic.setFont(Font.font(32)); can we use the same size for all the icons? ------------- PR Review: https://git.openjdk.org/jfx/pull/1387#pullrequestreview-5269387953 PR Review Comment: https://git.openjdk.org/jfx/pull/1387#discussion_r4064749938 PR Review Comment: https://git.openjdk.org/jfx/pull/1387#discussion_r4064707964 PR Review Comment: https://git.openjdk.org/jfx/pull/1387#discussion_r4064774391 PR Review Comment: https://git.openjdk.org/jfx/pull/1387#discussion_r4064690603
