On Mon, 21 Sep 2026 17:25:22 GMT, Andy Goryachev <[email protected]> wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo
>
> tests/performance/3DLighting/src/main/java/app/Benchmark.java line 65:
>
>> 63: var stopGraphic = createGraphic("⏹");
>> 64: stopGraphic.setFill(Color.RED);
>> 65: stopGraphic.setFont(Font.font(20));
>
> this sets graphic size to 20, but L182 it's 40 - that explains why they look
> different. use one size for all perhaps?
And then Windows is broken:
<img width="258" height="241" alt="image"
src="https://github.com/user-attachments/assets/5ce24615-4856-4c78-993e-bcff55f619bd";
/>
This is with size 40 on all 3 icons.
Someone who knows fonts needs to look at this.
> tests/performance/3DLighting/src/main/java/app/Benchmark.java line 252:
>
>> 250: double fps = elapsedFrames / elapsedSeconds;
>> 251: instantFps.set(fps);
>> 252: System.out.println("\ninstant fps: " + fps);
>
> these stats are printed to stdout - would it make more sense to shows them in
> let's say a status bar at the bottom?
They are already shown in the GUI at the Performance pane (that's what
`instantFps.set(fps);` does).
The printing is done to keep the previous results in a log-like fashion. They
are also legacy (Kevin wrote the fps counter, as well as the original quad).
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1387#discussion_r4065105355
PR Review Comment: https://git.openjdk.org/jfx/pull/1387#discussion_r4065066355
