On Thu, 17 Sep 2026 10:25:04 GMT, Nir Lisker <[email protected]> wrote:
>> Marius Hanl has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 17 commits: >> >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> junit6-upgrade >> - eclipse stuff >> - add missing junit-bom-6.1.3.pom >> - group junit dependencies >> - merge #2 >> - merge >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> junit6-upgrade >> - junit 6.1.3 >> - junit 6.1.2 >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> junit6-upgrade >> - ... and 7 more: https://git.openjdk.org/jfx/compare/517a4de7...8663e9e1 > > build.gradle line 2076: > >> 2074: dependencies { >> 2075: testImplementation group: "org.apiguardian", name: >> "apiguardian-api", version: "${apiguardianVersion}" >> 2076: testImplementation group: "org.jspecify", name: "jspecify", >> version: "${jspecifyVersion}" > > Why do we need to explicitly declare a dependency on jspecify is it's a > transitive dependency? When I leave it out, I get: 2 artifacts failed verification: - jspecify-1.0.0.jar (org.jspecify:jspecify:1.0.0) from repository MavenRepo - jspecify-1.0.0.module (org.jspecify:jspecify:1.0.0) from repository MavenRepo If the artifacts are trustworthy, you will need to update the gradle/verification-metadata.xml file. Which is weird because the used jspecify version is 1.0.1. So it is probably better to keep it. Also because of the closed build stuff. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1925#discussion_r4066772260
