On Fri, 25 Sep 2026 20:41:58 GMT, Nir Lisker <[email protected]> wrote:
>> Right, and the script skips JDK detection and forking for the new subproject >> in `allprojects`. What's the reason that you opted out of this path? > > I don't want more projects using the incorrect path. It will increase the > technical debt. Let's first separate "what needs to be done" from "how it is done". Here are the requirements for something being wired up to the build: 1. It must use the JDK specified by "$JDK_HOME" -- not just "look for a matching version", but "use this path". For GHA builds it means using the one we download. It doesn't matter what JDKs might or might not be available to the runners. Ditto for our closed CI builds. 2. The value of `--release` (or alternatively, `--source` and `--target`) needs to be JDK_TARGET_VERSION. Today, that means using the downloaded JDK 26 for compilation, and setting `--release 25`. When we bump the minimum version to 26 then both will be the same until we bump the boot JDK to 27, etc. So it looks like my suggestion of using JDK_TARGET_VERSION was wrong if that also affects what JDK is used. I think @mstr2 has a point when he suggests that it might be premature to use the Java toolchain, but we could still consider it as long as it can it satisfy 1 and 2. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2156#discussion_r4112168818
