On Sat, 26 Sep 2026 21:25:22 GMT, Florian Enner <[email protected]> wrote:
>> Marius Hanl has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains three commits: >> >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> JDK-8385270-Bump-JNI_VERSION-to-1.8-everywhere >> >> # Conflicts: >> # modules/javafx.graphics/src/main/native-iio/jpegloader.c >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> JDK-8385270-Bump-JNI_VERSION-to-1.8-everywhere >> - 8385270: Bump JNI_VERSION to 1.8 everywhere > > modules/javafx.media/src/main/native/jfxmedia/platform/ios/jni/com_sun_media_jfxmediaimpl_platform_ios_IOSPlatform.m > line 47: > >> 45: JNIEXPORT jint JNICALL JNI_OnLoad_jfxmedia(JavaVM *vm, void >> *reserved) { >> 46: >> 47: javavm = vm; > > accidental delete? the global probably still needs to be initialized good catch! Yes, this is indeed a weird one. The whole `javavm` variable seems unused. I readded the assignment. Maybe in the future it would make more sense to remove. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2175#discussion_r4115160074
