On Wed, 30 Sep 2026 15:03:32 GMT, Andy Goryachev <[email protected]> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove final, fix javadoc > > modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line > 201: > >> 199: final PseudoClassState triggerState = triggerStates[n]; >> 200: >> 201: // TODO: this means that a style like .menu-item:hover >> won't work. Need to separate CssStyleHelper tree from scene-graph tree > > is this still a TODO? to be addressed in a follow-up? I was wondering as well but I don't know really. The whole `Styleable` thing is weird. Usually, each `Styleable` is just some form of API/Contract which later results in a `Node` with the styles you added. Since only a `Node` can be added into the scene graph. Example: `Tab` is a `Styleable` but will never be observed here in the `CssStyleHelper`. Instead, it will be a `TabHeaderSkin` which will receive all style(classe)s from `Tab`. Same for `MenuItem`, which will be a `MenuItemContainer`. So I don't know why this `Styleable` thing exists here. And also there is `Styleable.getStyleableNode()` since JavaFX 9, which again raises more questions in my head. Like, why is it not used here, why does it exists,... ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2333#discussion_r4146723892
