On Wed, 7 Oct 2026 18:13:03 GMT, Marius Hanl <[email protected]> wrote:
> The second split PR of the CSS saga™. > > Some pre-existing issues were found once again in > https://github.com/openjdk/jfx/pull/2225, which were made more obvious with > the changes. > > When using a relative property like `-fx-padding: 1em;` with a font-size set > like this: `-fx-font-size: 20px;`, it may not correctly reset the padding as > soon as the font size is removed. > > In this example, the padding is 20, and when removed, it should reset to 0. > > Problem in code is simple: Two different code locations are similar, but not > completely, leading to a bug just with relative properties, but not otherwise. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). This is a nice, localized fix. Thank you for adding a test! modules/javafx.controls/src/test/java/test/javafx/scene/control/css/ControlCssTest.java line 90: > 88: } > 89: > 90: private static String toDataURL(String css) { at some point, we should move all these methods into the module's utils class. not now though. ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2337#pullrequestreview-5448120456 PR Review Comment: https://git.openjdk.org/jfx/pull/2337#discussion_r4211780194
