On Thu, 8 Oct 2026 17:29:43 GMT, Kevin Rushforth <[email protected]> wrote:
> This PR fixes a latent bug, by removing the `-msse2` setting from the media > Makefiles on macOS. > > Compiling JavaFX media on macOS / aarch64 with Xcode 26 or later fails with > an error: > > > $ gradle -PCOMPILE_MEDIA=true > ... > clang: error: unsupported option '-msse2' for target 'arm64-apple-macos-11' > > > On Xcode 15.4, this is a warning, but on Xcode 26 and later, it is an error. > > There is logic in the Makefile to only add `-msse2` on x64 systems, but it > fails because the `ARCH` parameter being passed into the Makefile is not > correct in all cases (it is set to `aarch64`, whereas macOS natively expects > `arm64`). > > On x64 systems, `-msse2` is enabled by default. So there is no need to set it > at all: This setting is redundant on x64 and actively harmful on aarch64 > systems. > > We might want to file a follow-up bug to fix the setting of `ARCH` for the > cases where it is incorrect, but that is a more intrusive change that would > need additional testing. Even if we eventually do that, removing `-msse2` is > still the right thing to do. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). - builds on my macOS with Xcode15.4+1.0 - the log shows no -msse2 - media player plays .mp3 and .mp4 in the monkey tester ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2340#pullrequestreview-5462087761
