On Fri, 9 Oct 2026 21:32:50 GMT, Kevin Rushforth <[email protected]> wrote:
>> Thanks, I'll re-review. >> >> The problem with `onInvalidating` (item 5 on my earlier list) can be done in >> a follow-up bug fix if you prefer, since it seems unlikely to cause problems >> in normal cases (and won't for JavaFX bindings classes). > >> I think [JDK-8334429](https://bugs.openjdk.org/browse/JDK-8334429) should be >> added to the resolved issues list here. @kevinrushforth It was discussed in >> [#1081 >> (comment)](https://github.com/openjdk/jfx/pull/1081#discussion_r4082305242), >> what do you think? > > Yes, I agree. The primary issue called out by that bug is addressed in this > PR, so a `/issue add JDK-8334429` command would be in order. > > There are a couple additional points that came out during the discussion in > that bug that could be considered for follow-up issues, but that doesn't > change the conclusion that JDK-8334429 is resolved with this PR. > > The two I saw from the comments in JDK-8334429 are: > > * Warn about using mutable objects with overridden equals in combination with > change listeners > * Deprecate collection property change listeners (e.g., on > `ObservableListValue`, etc) > > Both were discussed in this PR as well. @kevinrushforth I created the CSR, moved it to proposed and assigned it to you (I hope that was all correct): https://bugs.openjdk.org/browse/JDK-8394310 ------------- PR Comment: https://git.openjdk.org/jfx/pull/1081#issuecomment-6127177399
