On Mon, 12 Oct 2026 16:01:27 GMT, Marius Hanl <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove redundant invalidation note (covered by super interface) > > modules/javafx.base/src/test/java/test/com/sun/javafx/binding/ArrayManagerTest.java > line 238: > >> 236: assertEquals(manager.get(ArrayManagerTest.this, 0), >> "A"); >> 237: assertEquals(manager.get(ArrayManagerTest.this, 1), >> "B"); >> 238: assertEquals(manager.get(ArrayManagerTest.this, 2), >> "C"); > > Isn't this the wrong order? First the expected value, which is `A`. Otherwise > the error message would be misleading. Yep, you found the AssertJ user :) > modules/javafx.base/src/test/java/test/com/sun/javafx/binding/ListenerListBaseTest.java > line 490: > >> 488: assertListeners(list, List.of(il2, cl2)); >> 489: >> 490: assertEquals(null, list.get(0)); > > `assertNull` would be a better fit (better error message as well) I don't mind either way, it fits better with the rest of the asserts there... changed it for you. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r4251759694 PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r4251781055
