On Tue, 13 Oct 2026 16:30:34 GMT, Marius Hanl <[email protected]> wrote:

>> modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line 
>> 1006:
>> 
>>> 1004:             CssMetaData cssMetaData = entry.getKey();
>>> 1005:             try {
>>> 1006:                 resetToInitialValue(styleable, cssMetaData, 
>>> entry.getValue());
>> 
>> `resetToInitialValue()` might throw (in `applyStyle`), the entry is already 
>> removed on L996.  this makes it impossible to retry the reset after the 
>> condition is cleared, causing the previous value to remain.
>> 
>> should the entry be removed only after a successful reset?
>
> If anything, this is a preexisting issue. Again, I just reuse the already 
> existing reset method. It did not do that.

Nope, it is a regression.

Try this (using already existing harness):


.test:hover { -fx-boom:10; }


1. create ExceptionalPropertyControl node styled with "test"
2. set hover to true, applyCss
3. check boom==10
4. explodeOnApply=true
5. hover to false, applyCss
6. explodeOnApply=false
7. hover=true
8. hover=false
9. applyCss
10. verify boom=1

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2343#discussion_r4262989844

Reply via email to