On Wed, 19 Aug 2026 00:54:49 GMT, Michael Strauß <[email protected]> wrote:
> SplitPaneSkin's measurement and layout calculations are not correct when > pixel-snapping is enabled. There are quite a lot of mistakes that were made, > so this PR is quite large. Here is a list of what's changed: > > 1. Fixed X/Y snapping and cumulative re-snapping. > 2. Preserved fractional behavior when `snapToPixel` is false. > 3. Fixed content insets, clips, dragging, resizing, and divider positioning. > 4. Fixed bounded content-biased measurements. > 5. Fixed proportional layout below minimum size. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Just as a thought for those kinds of PRs for controls and skins that take a lot of time to review due to the amount of changes: Would it be possible to add them as separate classes e.g. `NewSplitPaneSkin`, fix all the issues one can find with it, and make it available similar to a preview feature? Either manually via setSkin or some property that will automatically choose the new skins when enabled. That way there is no risk of breaking existing controls, and people who are interested can still use the new version. There are quite a few badly broken skins I can think of that never got fixed properly due to concerns about breaking existing applications. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2263#issuecomment-6191398348
