On Fri, 18 Sep 2026 20:45:35 GMT, Andy Goryachev <[email protected]> wrote:
>> Florian Kirmaier has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull request >> contains one new commit since the last revision: >> >> JDK-8392158 >> fix how adjustRowHeights / adjustColumnWidths and >> CompositeSize.getProportionalMinOrMaxSize compute > > modules/javafx.graphics/src/test/java/test/javafx/scene/layout/GridPaneTest.java > line 3251: > >> 3249: fixedArea.assertSize(); >> 3250: } >> 3251: > > Do you think we should have this tests parameterized with different scales to > account for differences in snapping behavior (100%, 125, 150, 175, 200, 225)? I still think we should consider parameterizing these tests at different scales, as we do have to deal with rounding. what do you think? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2312#discussion_r4286101530
