On Wed, 14 Oct 2026 08:55:37 GMT, Marius Hanl <[email protected]> wrote:
>> Robert Lichtenberger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8264588: Split test case for windows / non-windows OS
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/behavior/TextAreaBehaviorTest.java
> line 152:
>
>> 150: @Test
>> 151: @Disabled("JDK-8393470")
>> 152: public void testDoubleClickSelectsCharacterClassBlocks() {
>
> Not a big fan of a big test that tests multiple things (in this case `#`,
> `...x`, ` `, `,,,`, `\t`) -- I'm more in favor of a parameterized test or
> separate tests.
> But this is a nitpick, so fine for me as is.
Most of the tests in this (currently disabled) test won't make it anyway, since
the discovery of the Windows special behavior. My idea of a simple "character
class block" selection algorithm is just not compatible with the idea of
selecting a word plus any subsequent whitespace...
When tackling JDK-8393470 I will most probably extract tests from this and
finally delete this test, which will be obsolete then.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2334#discussion_r4312949872
