On Wed, 7 Oct 2026 14:31:33 GMT, Florian Kirmaier <[email protected]> wrote:

>> When ContextMenu.show(node, side, x, y) is executed, the CSS is evaluated 
>> multiple times.
>> Of these 3 times, 2 process a non-final CSS state.
>> This leads to temporary, unnecessary changes.
>> 
>> This is fixed by properly defining the stylesheets and the 
>> ownerWindow/ownerNode properties of the context menu
>> before applyCss is called. The previous solution was incomplete and resulted 
>> in unnecessary CSS calls.
>> 
>> Slightly related to my other PR: https://github.com/openjdk/jfx/pull/2213
>> But it is fixed in a way that works independently of it.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Florian Kirmaier has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8388313: PR feedback1

modules/javafx.controls/src/main/java/javafx/scene/control/ContextMenu.java 
line 256:

> 254: 
> 255:         
> PopupWindowHelper.ownerWindow(this).set(anchor.getScene().getWindow());
> 256:         PopupWindowHelper.ownerNode(this).set(anchor);

possible regression: this PR disables autohide, see JDK-811638

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2215#discussion_r4415747599

Reply via email to