On Wed, 9 Sep 2026 07:34:44 GMT, Nir Lisker <[email protected]> wrote:

> * Updated the `java` plugin to the `java-library` plugin, which allows 
> automatic library configurations. It has no effect in this PR, but is a 
> necessary step for correct dependency wiring.
> * Moved (as-is) the block that defines module paths above the `allprojects` 
> configuration to make the paths available for later code.
> * Unified the `ext` properties, module source paths, and verification checks 
> configurations for modular projects in `allprojects` (from their repeating 
> individual blocks).
> * Removed redundant source sets: the `java` plugin already defines the 
> [`main` and `test` source 
> sets](https://docs.gradle.org/current/userguide/java_plugin.html#source_sets) 
> and makes the project dependent on them. The `shims` are already configured 
> separately in the other `allprojects` with 
> `project.sourceSets.shims.java.srcDirs += 
> project.sourceSets.main.java.srcDirs` etc. (which is also not the right way 
> of doing it), so their current definition is redundant.
> 
> I've tested with `win.gradle`'s `WIN.compileSwing = false` and with 
> `WIN.compileSWT = false` in addition to the standard `sdk` and `test` in 
> various scenarios.
> 
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

I don't have time to review it right now, but I can confirm that our closed 
build fails. Will look into it when I have time.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2305#issuecomment-6708891331

Reply via email to