On Fri, 30 Oct 2026 14:07:56 GMT, Thiago Milczarek Sayao <[email protected]> 
wrote:

>> Marius Hanl has updated the pull request with a new target base due to a 
>> merge or a rebase. The incremental webrev excludes the unrelated changes 
>> brought in by the merge/rebase. The pull request contains two additional 
>> commits since the last revision:
>> 
>>  - Merge branch 'master' of https://github.com/openjdk/jfx into 
>> 8156779-GTK3-warning-when-running-SwingNode-applications
>>  - 8156779: GTK3: warning when running SwingNode applications
>
> modules/javafx.graphics/src/main/native-glass/gtk/GlassApplication.cpp line 
> 59:
> 
>> 57: static int glass_x_error_handler(Display*, XErrorEvent*)
>> 58: {
>> 59:     return 0;
> 
> Maybe print the output of [XGetErrorText() 
> ](https://tronche.com/gui/x/xlib/event-handling/protocol-errors/XGetErrorText.html)
>  in DEBUG builds?

Not sure if I understand correctly. This is only installed for the `#ifndef 
VERBOSE` case.
Debug builds will compile with `-DVERBOSE`, so this handler is not installed at 
all for debug builds.
-> Full error is printed and the app will exit.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2296#discussion_r4502935451

Reply via email to