> This is the continuation of the split of the Maven publishing made in 
> https://github.com/openjdk/jfx/pull/1970.
> Since the `build.gradle` file had become so large, adding more Maven code was 
> out of question in the past.
> Thanks to the split, we can now quickly and easily add support for JavaFX 
> Sources, thereby significantly simplifying testing.
> 
> This can be tested by:
> 
> `./gradlew publishToMavenLocal -PMAVEN_PUBLISH=true -PMAVEN_VERSION=custom`
> 
> This will create a JavaFX version named 'custom' in your .m2 folder (under 
> `~/.m2/org/openjfx/javafx-XXX/custom`).
> The sources should be there as well now.
> 
> The original PR https://github.com/openjdk/jfx/pull/2144 can not be reopened 
> because I force pushed it, see the bot comment here: 
> https://github.com/openjdk/jfx/pull/2144#issuecomment-5398495316
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Marius Hanl has updated the pull request with a new target base due to a merge 
or a rebase. The incremental webrev excludes the unrelated changes brought in 
by the merge/rebase. The pull request contains four additional commits since 
the last revision:

 - Merge branch 'master' of https://github.com/openjdk/jfx into 
8276170-gradle-jfx-sources
 - review
 - Merge branch 'master' of https://github.com/openjdk/jfx into 
8276170-gradle-jfx-sources
 - 8276170: Create Sources when publishing to Maven

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/2273/files
  - new: https://git.openjdk.org/jfx/pull/2273/files/c44da0ea..a4e287a7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=2273&range=02
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=2273&range=01-02

  Stats: 812 lines in 26 files changed: 472 ins; 253 del; 87 mod
  Patch: https://git.openjdk.org/jfx/pull/2273.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/2273/head:pull/2273

PR: https://git.openjdk.org/jfx/pull/2273

Reply via email to