On Tue, 10 Nov 2026 15:02:02 GMT, Marius Hanl <[email protected]> wrote:

>> The "show details" hyperlink button in an alert dialog that has an 
>> expandable detail area wipes out its base style class by overwriting all 
>> styles. This means styling in modena.css that targets `.hyperlink` is no 
>> longer applied, like the default text fill colors.
>> 
>> The culprit is this code in DialogPane:
>> 
>>         InvalidationListener expandedListener = o -> {
>>             final boolean isExpanded = isExpanded();
>>             detailsButton.setText(isExpanded ? lessText : moreText);
>>             detailsButton.getStyleClass().setAll("details-button", 
>> (isExpanded ? "less" : "more")); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
>>         };
>> 
>> Here it uses `setAll` to set styles, wiping out the default `.hyperlink` 
>> style from "Hyperlink detailsButton = new HyperLink()"
>
> modules/javafx.controls/src/main/java/javafx/scene/control/DialogPane.java 
> line 822:
> 
>> 820:         final ObservableList<String> styleClasses = 
>> detailsButton.getStyleClass();
>> 821: 
>> 822:         styleClasses.add("details-button");  //$NON-NLS-1$
> 
> can you remove the `//$NON-NLS-1$` everywhere?

+1!

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1779#discussion_r4526575914

Reply via email to