On Mon, 16 Nov 2026 18:43:37 GMT, Jose Pereda <[email protected]> wrote:
>> This PR removes the stage from the active windows list after the stage gets >> hidden/closed, preventing a possible NPE in WindowStage::setIconified. >> >> Similar to [JDK-8387626](https://bugs.openjdk.org/browse/JDK-8387626), that >> got fixed removing the stage from the active windows list after there was a >> `WindowEvent.DESTROY` event in `GlassWindowEventHandler::get`, in this case >> the Window::hide` event doesn't produce a `WindowEvent.CLOSE` event. >> Therefore, the fix goes directly in `WindowStage::close`. >> >> A system test that fails before the proposed fix, and passes after it, has >> been included. >> >> --------- >> - [X] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Jose Pereda has updated the pull request incrementally with one additional > commit since the last revision: > > Address feedback tests/system/src/test/java/test/javafx/stage/CloseWindowTest.java line 113: > 111: childStage.setScene(new Scene(new StackPane(new Label("Child > stage")), 200, 120)); > 112: > 113: childStage.setOnHidden(_ -> doneLatch.countDown()); I am afraid this did not fix the test: this event is sent before `requestFocus()` on L74. The native focus events might come after runAndWait() so the tests won't catch the NPE. maybe use the fact that focus is restored as a completion criteria? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2373#discussion_r4590019850
