On Mon, 16 Nov 2026 14:46:44 GMT, Marius Hanl <[email protected]> wrote:

>> Michael Strauß has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   use GtkStyleContext instead of GtkStyle
>
> modules/javafx.graphics/src/main/native-glass/gtk/PlatformSupport.cpp line 92:
> 
>> 90:     : env(env),
>> 91:       application(env->NewGlobalRef(application)),
>> 92:       styleContext(gtk_style_context_new()),
> 
> If I understand the documentation correctly, we might be able to use that 
> style context also in `collectPreferences`? This would allow to replace the 2 
> deprecated methods `gtk_style_new` and `gtk_style_lookup_color`.
> 
> The GTK docs suggest in 
> https://docs.gtk.org/gtk3/method.Style.lookup_color.html to use 
> `gtk_style_context_lookup_color` (with a `GtkStyleContext`).
> 
> Might be better as follow up, but interested if I this might make sense.

Since `GtkStyle` just wraps `GtkStyleContext` internally, it makes sense to use 
it directly as we now have a long-lived style context.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2372#discussion_r4604276277

Reply via email to