[email protected] wrote: > URL: ftp://ftp.openldap.org/incoming/douglas-royds-181026.patch > > This updated patch also sets the date and time strings to the > SOURCE_DATE_EPOCH.
Are you intending a SOURCE_DATE_EPOCH to be a Unix time value? I.e., an integer? This value format needs to be documented. Unfortunately, your use of date -d is nonportable, it appears that only the GNU tools understand this option. It will fail on other platforms like *BSD, Solaris, that aren't using a GNU userland. Why can't you simply provide an already formatted date & time that can be used directly, instead of needing to be reformatted here? > The WHOWHERE string will now be set to simply "openldap" in the case > that a SOURCE_DATE_EPOCH is set. > > Tait Communications Ltd hereby place the following modifications to > OpenLDAP Software (and only these modifications) into the public domain. > Hence, these modifications may be freely used and/or redistributed for > any purpose with or without attribution and/or other notice. > > > > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
