Review: Approve
Eric4 files are gone! Awesome branch! :-P

+        log.debug(u'build_text_rectangle ')
+        log.debug(u'generate preview ')

May I be extremely pedantic and ask why there are trailing spaces?

+        if self.displayBlank == False:

I prefer code like "if not self.displayBlank" (unless displayBlank could 
legitimately be None and needs to be treated differently).

 review approve

-- 
https://code.launchpad.net/~trb143/openlp/servicing/+merge/6161
Your team openlp.org Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to