Review: Approve Looks fine. Just 2 things though. Firstly, coding standards - but I understand that this is "legacy" code, so that's fine.
Secondly, if you're working on the songs plugin, rather create a new branch off trunk with an appropriate name (like "songsplugin"). It's the reason we went with Bazaar :-) -- https://code.launchpad.net/~trb143/openlp/servicing/+merge/7089 Your team openlp.org Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
