Review: Approve
Stylistic niggles:
u'SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\SQLite ODBC
Driver'
could be done as:
ur'SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\SQLite ODBC Driver'
Technically, in
171 + subprocess.call(cmd, stdout=open(u'./sqlite.dmp', u'w'))
the forward slash is non-Windowsy. But
subprocess.call(cmd, stdout=open(u'sqlite.dmp', u'w'))
would have the same effect anyway.
(Like at line 184 - I just noticed :)
--
https://code.launchpad.net/~j-corwin/openlp/migration/+merge/13543
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
