On Fri, Jun 25, 2010 at 02:44:27PM -0000 or thereabouts, Raoul Snyman wrote: > I'm not sure how Jonathan's SofImporter and OOoImporter work, but the Bible > Importers all inherit from the base "BibleDB" class, which is the Bible's > equivalent to the SongImporter class. > > For example: > > class OpenSongImporter(SongImporter): > ... >
Yes, I think that would be better. It's not quite like that at the moment - SongImport is a member of the class, rather than something inherited from, so I built this one the same. I guess in future it should be refactored to work as the Bible plugin does. Cheers, Martin -- https://code.launchpad.net/~mjthompson/openlp/opensong_import/+merge/28466 Your team OpenLP Core is requested to review the proposed merge of lp:~mjthompson/openlp/opensong_import into lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
