Review: Needs Fixing Comment lines 104, 111, 136 are too long. Missing spaces around operators on lines: 217, 226, 239, 258
In songimport, you've replaced property ccli_number with song_cclino, yet created a set_ccli_number method which sets ccli_number. Is this correct? Do we want the test routines in trunk? They are generally forgotten about and I think a load of such routines were previously deleted. Also a few missing spaces around ='s in these. -- https://code.launchpad.net/~mjthompson/openlp/opensong_import/+merge/29420 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
