Review: Needs Fixing 1. Don't understand why in some places you're doing a = foo.bar b = bar.foo if a == b:
instead of doing foo.bar == bar.foo (e.g. checkAuthor) You've also typoed first as fist in here. Line 102: typoed existed Line 120 (and others): I think "x is False", should rather be "not x" Line 245: Typoed cannot -- https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/29636 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
