Some notes:
- You can rename the "master_manager" argument to "manager" in the constructor
- You don't need to manually set the manager, it is set in SongImport
- If you're checking for the existence of "filenames" I'd suggest raising an
exception if it isn't there
def __init__(self, manager, **kwargs):
SongImport.__init__(self, manager)
if u'filenames' in kwargs:
self.filenames = kwargs[u'filenames']
log.debug(self.filenames)
else:
raise KeyError(u'Keyword argument "filenames" not supplied.')
--
https://code.launchpad.net/~derek-scotney/openlp/songselectfileimport/+merge/34128
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
