Review: Needs Fixing
13 + self.addToService([None], self.remoteTriggered)
Why do you have a None in your list? Just send through an empty list.
63 + ul.find("#go-live").click(OpenLP.goLive);
64 + ul.find("#add-service").click(OpenLP.addToService);
Why use the "find"? Instead of passing jQuery a whole clump of HTML (which it
has to parse into objects), just create an anchor and assign the click
immediately.
I need to branch this and play around with it too before I'll approve it 100%,
but I'll only get to that this afternoon...
--
https://code.launchpad.net/~j-corwin/openlp/remote/+merge/61840
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
